> On Aug. 20, 2015, 7:06 p.m., Ajay Yadava wrote: > > lens-ui/README.markdown, line 24 > > <https://reviews.apache.org/r/37530/diff/5/?file=1045044#file1045044line24> > > > > You can use Maven frontend plugin > > (https://github.com/eirslett/frontend-maven-plugin) to integrate it with > > maven.
I'll check this out. And update! > On Aug. 20, 2015, 7:06 p.m., Ajay Yadava wrote: > > lens-ui/package.json, line 17 > > <https://reviews.apache.org/r/37530/diff/5/?file=1045085#file1045085line17> > > > > https://github.com/STRML/keyMirror doesn't contain license info, not > > sure about it's usage. It's open-source only. And freely distributed. > On Aug. 20, 2015, 7:06 p.m., Ajay Yadava wrote: > > lens-ui/server.js, line 24 > > <https://reviews.apache.org/r/37530/diff/5/?file=1045086#file1045086line24> > > > > Shouldn't the console.log().. statements be removed? It is not > > guaranteed to be defined in all browsers at all times. It'll always run in node environment and will be present. It helps the user to know on which port the app will run. I can remove this too. But it's harmless. - Ankeet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37530/#review95985 ----------------------------------------------------------- On Aug. 24, 2015, 6:45 p.m., Ankeet Maini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37530/ > ----------------------------------------------------------- > > (Updated Aug. 24, 2015, 6:45 p.m.) > > > Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat > Khandelwal, sharad agarwal, and Yash Sharma. > > > Repository: lens > > > Description > ------- > > LENS-629 - A new improved web client > > > Diffs > ----- > > .gitignore d0fa424 > lens-ui/README.markdown PRE-CREATION > lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION > lens-ui/app/actions/LoginActions.js PRE-CREATION > lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION > lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION > lens-ui/app/adapters/BaseAdapter.js PRE-CREATION > lens-ui/app/app.js PRE-CREATION > lens-ui/app/components/AboutComponent.js PRE-CREATION > lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION > lens-ui/app/components/AppComponent.js PRE-CREATION > lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION > lens-ui/app/components/CubeTreeComponent.js PRE-CREATION > lens-ui/app/components/DatabaseComponent.js PRE-CREATION > lens-ui/app/components/HeaderComponent.js PRE-CREATION > lens-ui/app/components/LoaderComponent.js PRE-CREATION > lens-ui/app/components/LoginComponent.js PRE-CREATION > lens-ui/app/components/LogoutComponent.js PRE-CREATION > lens-ui/app/components/QueryBoxComponent.js PRE-CREATION > lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION > lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION > lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION > lens-ui/app/components/QueryResultsComponent.js PRE-CREATION > lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION > lens-ui/app/components/SidebarComponent.js PRE-CREATION > lens-ui/app/components/TableSchemaComponent.js PRE-CREATION > lens-ui/app/components/TableTreeComponent.js PRE-CREATION > lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION > lens-ui/app/constants/AppConstants.js PRE-CREATION > lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION > lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION > lens-ui/app/stores/CubeStore.js PRE-CREATION > lens-ui/app/stores/DatabaseStore.js PRE-CREATION > lens-ui/app/stores/TableStore.js PRE-CREATION > lens-ui/app/stores/UserStore.js PRE-CREATION > lens-ui/app/styles/css/global.css PRE-CREATION > lens-ui/app/styles/css/login.css PRE-CREATION > lens-ui/app/styles/css/query-component.css PRE-CREATION > lens-ui/app/styles/css/tree.css PRE-CREATION > lens-ui/app/styles/less/globals.less PRE-CREATION > lens-ui/config.json PRE-CREATION > lens-ui/index.html PRE-CREATION > lens-ui/package.json PRE-CREATION > lens-ui/server.js PRE-CREATION > lens-ui/webpack.config.js PRE-CREATION > > Diff: https://reviews.apache.org/r/37530/diff/ > > > Testing > ------- > > No server code added/modified. Just JavaScript! > > > File Attachments > ---------------- > > License details of NPM packages > > https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt > > > Thanks, > > Ankeet Maini > >
