> On Sept. 1, 2015, 5:29 a.m., Amareshwari Sriramadasu wrote: > > lens-ui/package.json, line 1 > > <https://reviews.apache.org/r/37530/diff/6/?file=1048619#file1048619line1> > > > > Same as earlier. Can you include license header with json commnents?
We cannot add comments to a json file. https://plus.google.com/+DouglasCrockfordEsq/posts/RK8qyGVaGSr One is config.json, which I can rename to config.data but package.json can't be renamed as it is looked up by npm (Node package manager) analogous to mvn which looks for pom.xml. So can we add an exception in the rules to ignore .json files? - Ankeet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37530/#review97254 ----------------------------------------------------------- On Sept. 1, 2015, 5:30 a.m., Ankeet Maini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37530/ > ----------------------------------------------------------- > > (Updated Sept. 1, 2015, 5:30 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat > Khandelwal, sharad agarwal, and Yash Sharma. > > > Bugs: LENS-629 > https://issues.apache.org/jira/browse/LENS-629 > > > Repository: lens > > > Description > ------- > > LENS-629 - A new improved web client > > > Diffs > ----- > > .gitignore d0fa424 > lens-ui/README.markdown PRE-CREATION > lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION > lens-ui/app/actions/LoginActions.js PRE-CREATION > lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION > lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION > lens-ui/app/adapters/BaseAdapter.js PRE-CREATION > lens-ui/app/app.js PRE-CREATION > lens-ui/app/components/AboutComponent.js PRE-CREATION > lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION > lens-ui/app/components/AppComponent.js PRE-CREATION > lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION > lens-ui/app/components/CubeTreeComponent.js PRE-CREATION > lens-ui/app/components/DatabaseComponent.js PRE-CREATION > lens-ui/app/components/HeaderComponent.js PRE-CREATION > lens-ui/app/components/LoaderComponent.js PRE-CREATION > lens-ui/app/components/LoginComponent.js PRE-CREATION > lens-ui/app/components/LogoutComponent.js PRE-CREATION > lens-ui/app/components/QueryBoxComponent.js PRE-CREATION > lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION > lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION > lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION > lens-ui/app/components/QueryResultsComponent.js PRE-CREATION > lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION > lens-ui/app/components/SidebarComponent.js PRE-CREATION > lens-ui/app/components/TableSchemaComponent.js PRE-CREATION > lens-ui/app/components/TableTreeComponent.js PRE-CREATION > lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION > lens-ui/app/constants/AppConstants.js PRE-CREATION > lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION > lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION > lens-ui/app/stores/CubeStore.js PRE-CREATION > lens-ui/app/stores/DatabaseStore.js PRE-CREATION > lens-ui/app/stores/TableStore.js PRE-CREATION > lens-ui/app/stores/UserStore.js PRE-CREATION > lens-ui/app/styles/css/global.css PRE-CREATION > lens-ui/app/styles/css/login.css PRE-CREATION > lens-ui/app/styles/css/query-component.css PRE-CREATION > lens-ui/app/styles/css/tree.css PRE-CREATION > lens-ui/app/styles/less/globals.less PRE-CREATION > lens-ui/config.json PRE-CREATION > lens-ui/index.html PRE-CREATION > lens-ui/package.json PRE-CREATION > lens-ui/server.js PRE-CREATION > lens-ui/webpack.config.js PRE-CREATION > > Diff: https://reviews.apache.org/r/37530/diff/ > > > Testing > ------- > > No server code added/modified. Just JavaScript! > > > File Attachments > ---------------- > > License details of NPM packages > > https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt > > > Thanks, > > Ankeet Maini > >
