> On Sept. 10, 2015, 11:02 a.m., Rajat Khandelwal wrote:
> > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java,
> > line 74
> > <https://reviews.apache.org/r/37934/diff/6/?file=1066468#file1066468line74>
> >
> > Make default pagination configurable.
I was using @DefaultValue annotation to inject default values in service calls
@DefaultValue(defaultStart) @QueryParam("start") int start,
If I make this configurable, I need to remove this annotation and do the check
inside the function (@DefaultValue takes only final static inline declared
values)
- Amruth
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/37934/#review98369
-----------------------------------------------------------
On Sept. 9, 2015, 7:23 p.m., Amruth Sampath wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/37934/
> -----------------------------------------------------------
>
> (Updated Sept. 9, 2015, 7:23 p.m.)
>
>
> Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat
> Khandelwal, and sharad agarwal.
>
>
> Repository: lens
>
>
> Description
> -------
>
> Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742
> (Note : Sharing and CLI are not a part of this patch)
>
>
> Diffs
> -----
>
> lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java
> 754e6e1
> lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java
> PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java
> PRE-CREATION
>
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java
> PRE-CREATION
>
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java
> PRE-CREATION
>
> lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java
> PRE-CREATION
>
> lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java
> PRE-CREATION
> lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java
> PRE-CREATION
> lens-api/src/main/resources/lens-errors.conf 5428041
>
> lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java
> fb11f93
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java
> PRE-CREATION
>
> lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java
> PRE-CREATION
>
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java
> PRE-CREATION
>
> lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java
> PRE-CREATION
> lens-server/enunciate.xml 94b5199
>
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java
> PRE-CREATION
>
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java
> PRE-CREATION
>
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java
> PRE-CREATION
>
> lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java
> PRE-CREATION
> lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java
> 5d77eb7
> lens-server/src/main/resources/lensserver-default.xml 5d33eda
>
> lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java
> PRE-CREATION
> lens-server/src/test/resources/lens-site.xml 4cf94d5
> src/site/apt/admin/config.apt b163a3a
> src/site/apt/user/index.apt 6a86b1b
>
> Diff: https://reviews.apache.org/r/37934/diff/
>
>
> Testing
> -------
>
> Have added unit test cases for parsing, resolution of parameter and service
> testing.
>
>
> Thanks,
>
> Amruth Sampath
>
>
