Hi Amereshwari, Syntax error was never in Lenscommonerrorcode. It was always in Lenscubeerrorcode.
Initially I added it in Lenscommonerrorcode for saved queries also for some validation purposes but later removed it. Syntaxerror is still present in Lenscubeerrorcode. (sent from mobile, excuse typos!) Thanks, On Sep 11, 2015 1:49 PM, "Amareshwari Sriramadasu" <[email protected]> wrote: > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37934/ > > On September 10th, 2015, 7:49 a.m. UTC, *Rajat Khandelwal* wrote: > > lens-api/src/main/resources/lens-errors.conf > <https://reviews.apache.org/r/37934/diff/6/?file=1066449#file1066449line105> > (Diff > revision 6) 78 > > errorCode = 3001 > > 79 > > httpStatusCode = ${BAD_REQUEST} > > 80 > > errorMsg = "Syntax Error: %s" > > 81 > > } > > Why do we need to remove it? > > On September 10th, 2015, 9:24 a.m. UTC, *Amruth Sampath* wrote: > > There is an INVALID_XML_ERROR in LensCommonErrorCode which is best suited to > this. > > On September 10th, 2015, 10:30 a.m. UTC, *Rajat Khandelwal* wrote: > > syntax error was supposed to be for syntax errors in queries. But now invalid > queries are not accepted so I guess removing should be fine. > > Reopening this comment. SYNTAX_ERROR still comes from queries with invalid > syntax and the mapping should not be removed. > > > - Amareshwari > > On September 11th, 2015, 8:01 a.m. UTC, Amruth Sampath wrote: > Review request for lens, Amareshwari Sriramadasu, Pranav Agarwal, Rajat > Khandelwal, and sharad agarwal. > By Amruth Sampath. > > *Updated Sept. 11, 2015, 8:01 a.m.* > *Repository: * lens > Description > > Refer to the JIRA description - https://issues.apache.org/jira/browse/LENS-742 > (Note : Sharing and CLI are not a part of this patch) > > Testing > > Have added unit test cases for parsing, resolution of parameter and service > testing. > > Diffs > > - lens-api/src/main/java/org/apache/lens/api/error/LensCommonErrorCode.java > (754e6e1) > - lens-api/src/main/java/org/apache/lens/api/query/save/ListResponse.java > (PRE-CREATION) > - lens-api/src/main/java/org/apache/lens/api/query/save/Parameter.java > (PRE-CREATION) > - > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterCollectionType.java > (PRE-CREATION) > - > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterDataType.java > (PRE-CREATION) > - > lens-api/src/main/java/org/apache/lens/api/query/save/ParameterParserResponse.java > (PRE-CREATION) > - > lens-api/src/main/java/org/apache/lens/api/query/save/ResourceModifiedResponse.java > (PRE-CREATION) > - lens-api/src/main/java/org/apache/lens/api/query/save/SavedQuery.java > (PRE-CREATION) > - lens-api/src/main/resources/lens-errors.conf (5428041) > - > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > (fb11f93) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryHelper.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/SavedQueryService.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/MissingParameterException.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterCollectionException.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ParameterValueException.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/PrivilegeException.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/SavedQueryNotFound.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/exception/ValueEncodeException.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterCollectionTypeEncoder.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterDataTypeEncoder.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterParser.java > (PRE-CREATION) > - > lens-server-api/src/main/java/org/apache/lens/server/api/query/save/param/ParameterResolver.java > (PRE-CREATION) > - > lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterParser.java > (PRE-CREATION) > - > lens-server-api/src/test/java/org/apache/lens/server/api/query/save/TestParameterResolution.java > (PRE-CREATION) > - lens-server/enunciate.xml (94b5199) > - > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryApp.java > (PRE-CREATION) > - > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryDao.java > (PRE-CREATION) > - > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryResource.java > (PRE-CREATION) > - > lens-server/src/main/java/org/apache/lens/server/query/save/SavedQueryServiceImpl.java > (PRE-CREATION) > - lens-server/src/main/java/org/apache/lens/server/util/UtilityMethods.java > (5d77eb7) > - lens-server/src/main/resources/lensserver-default.xml (5d33eda) > - > lens-server/src/test/java/org/apache/lens/server/query/save/TestSavedQueryService.java > (PRE-CREATION) > - lens-server/src/test/resources/lens-site.xml (4cf94d5) > - src/site/apt/admin/config.apt (b163a3a) > - src/site/apt/user/index.apt (6a86b1b) > > View Diff <https://reviews.apache.org/r/37934/diff/> >
