> On Sept. 19, 2015, 10:58 a.m., Amareshwari Sriramadasu wrote: > > lens-ui/pom.xml, lines 58-59 > > <https://reviews.apache.org/r/37530/diff/9/?file=1077454#file1077454line58> > > > > Can these be defined in parent pom?
Yes. > On Sept. 19, 2015, 10:58 a.m., Amareshwari Sriramadasu wrote: > > pom.xml, lines 550-552 > > <https://reviews.apache.org/r/37530/diff/9/?file=1077457#file1077457line550> > > > > Can these folders be moved to target/ ? Otherwise, how will they get > > cleaned up in next build? > > Ankeet Maini wrote: > Only assets can be moved inside target folder which contains the bundled, > minified and transpiled source files which is under my control. > > As to node_modules, it is used by Node package manager to look the > dependencies, and other dependencies also look inside it to find its > dependencies in a recursive manner. So it can't be changed. It's also cited > here in the npm FAQ > https://docs.npmjs.com/misc/faq#node-modules-is-the-name-of-my-deity-s-arch-rival-and-a-forbidden-word-in-my-religion-can-i-configure-npm-to-use-a-different-folder > > Also we would not want to move node folder which contains the node js > installation files. If we were to change that, after every mvn clean install, > the maven goal would download the entire node package which would be too > costly and time consuming affair. This node folder would be created by the > maven plugin(frontend-maven-plugin) to install nodejs locally while doing an > mvn compile, so that nodejs is not a prerequisite for backend developers as > it earlier was. It'll not conflict with any existing installation and will be > available only locally. Moved the assets folder to target. Updated patch. - Ankeet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/37530/#review99666 ----------------------------------------------------------- On Sept. 22, 2015, 6:24 a.m., Ankeet Maini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/37530/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2015, 6:24 a.m.) > > > Review request for lens, Amareshwari Sriramadasu, Jaideep dhok, Rajat > Khandelwal, sharad agarwal, and Yash Sharma. > > > Bugs: LENS-629 > https://issues.apache.org/jira/browse/LENS-629 > > > Repository: lens > > > Description > ------- > > LENS-629 - A new improved web client > > > Diffs > ----- > > .gitignore 5a356e0 > lens-ui/LICENSE PRE-CREATION > lens-ui/README.markdown PRE-CREATION > lens-ui/app/actions/AdhocQueryActions.js PRE-CREATION > lens-ui/app/actions/LoginActions.js PRE-CREATION > lens-ui/app/adapters/AdhocQueryAdapter.js PRE-CREATION > lens-ui/app/adapters/AuthenticationAdapter.js PRE-CREATION > lens-ui/app/adapters/BaseAdapter.js PRE-CREATION > lens-ui/app/app.js PRE-CREATION > lens-ui/app/components/AboutComponent.js PRE-CREATION > lens-ui/app/components/AdhocQueryComponent.js PRE-CREATION > lens-ui/app/components/AppComponent.js PRE-CREATION > lens-ui/app/components/CubeSchemaComponent.js PRE-CREATION > lens-ui/app/components/CubeTreeComponent.js PRE-CREATION > lens-ui/app/components/DatabaseComponent.js PRE-CREATION > lens-ui/app/components/HeaderComponent.js PRE-CREATION > lens-ui/app/components/LoaderComponent.js PRE-CREATION > lens-ui/app/components/LoginComponent.js PRE-CREATION > lens-ui/app/components/LogoutComponent.js PRE-CREATION > lens-ui/app/components/QueryBoxComponent.js PRE-CREATION > lens-ui/app/components/QueryDetailResultComponent.js PRE-CREATION > lens-ui/app/components/QueryOperationsComponent.js PRE-CREATION > lens-ui/app/components/QueryPreviewComponent.js PRE-CREATION > lens-ui/app/components/QueryResultsComponent.js PRE-CREATION > lens-ui/app/components/RequireAuthenticationComponent.js PRE-CREATION > lens-ui/app/components/SidebarComponent.js PRE-CREATION > lens-ui/app/components/TableSchemaComponent.js PRE-CREATION > lens-ui/app/components/TableTreeComponent.js PRE-CREATION > lens-ui/app/constants/AdhocQueryConstants.js PRE-CREATION > lens-ui/app/constants/AppConstants.js PRE-CREATION > lens-ui/app/dispatcher/AppDispatcher.js PRE-CREATION > lens-ui/app/stores/AdhocQueryStore.js PRE-CREATION > lens-ui/app/stores/CubeStore.js PRE-CREATION > lens-ui/app/stores/DatabaseStore.js PRE-CREATION > lens-ui/app/stores/TableStore.js PRE-CREATION > lens-ui/app/stores/UserStore.js PRE-CREATION > lens-ui/app/styles/css/global.css PRE-CREATION > lens-ui/app/styles/css/login.css PRE-CREATION > lens-ui/app/styles/css/query-component.css PRE-CREATION > lens-ui/app/styles/css/tree.css PRE-CREATION > lens-ui/app/styles/less/globals.less PRE-CREATION > lens-ui/config.json PRE-CREATION > lens-ui/index.html PRE-CREATION > lens-ui/package.json PRE-CREATION > lens-ui/pom.xml PRE-CREATION > lens-ui/server.js PRE-CREATION > lens-ui/webpack.config.js PRE-CREATION > pom.xml adba544 > > Diff: https://reviews.apache.org/r/37530/diff/ > > > Testing > ------- > > No server code added/modified. Just JavaScript! > > > File Attachments > ---------------- > > License details of NPM packages > > https://reviews.apache.org/media/uploaded/files/2015/08/24/b4bb6d72-b98f-4f12-8bdb-3cea0544c94f__license-details.txt > > > Thanks, > > Ankeet Maini > >
