> On Nov. 16, 2015, 7:08 a.m., Rajat Khandelwal wrote: > > lens-ui/app/components/QueryBoxComponent.js, lines 344-348 > > <https://reviews.apache.org/r/40333/diff/1/?file=1125835#file1125835line344> > > > > This is just for optimization, right?
Yes, earlier, the description and name was mixed with params, and wasn't easy to track. So made it separate. - Ankeet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40333/#review106600 ----------------------------------------------------------- On Nov. 15, 2015, 7:41 p.m., Ankeet Maini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40333/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2015, 7:41 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Saved query UI component refactor. > > > Diffs > ----- > > lens-ui/app/components/QueryBoxComponent.js 6f4eeb7 > lens-ui/app/components/QueryParamRowComponent.js fb5f5da > lens-ui/app/components/QueryParamsComponent.js a49e338 > lens-ui/app/components/SavedQueryPreviewComponent.js 4f9459a > > Diff: https://reviews.apache.org/r/40333/diff/ > > > Testing > ------- > > > Thanks, > > Ankeet Maini > >
