> On Nov. 16, 2015, 9:26 a.m., Rajat Khandelwal wrote: > > lens-ui/app/components/QueryBoxComponent.js, line 19 > > <https://reviews.apache.org/r/40333/diff/1/?file=1125835#file1125835line19> > > > > Can you mention the changes as experienced on UI? And testing done for > > those?
On UI, if you were in the middle of editing a Saved Query, and then before you Cancel'ed or Saved it, opened another one then the description would not get updated. Also, sometimes, the previous values lurked even on creating a new saved query. That's why I've refctored the SavedQuery Components. Test cases for UI don't exist now, but I'll add soon. - Ankeet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/40333/#review106620 ----------------------------------------------------------- On Nov. 15, 2015, 7:41 p.m., Ankeet Maini wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/40333/ > ----------------------------------------------------------- > > (Updated Nov. 15, 2015, 7:41 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > Saved query UI component refactor. > > > Diffs > ----- > > lens-ui/app/components/QueryBoxComponent.js 6f4eeb7 > lens-ui/app/components/QueryParamRowComponent.js fb5f5da > lens-ui/app/components/QueryParamsComponent.js a49e338 > lens-ui/app/components/SavedQueryPreviewComponent.js 4f9459a > > Diff: https://reviews.apache.org/r/40333/diff/ > > > Testing > ------- > > > Thanks, > > Ankeet Maini > >
