[ 
https://issues.apache.org/jira/browse/LENS-868?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15014889#comment-15014889
 ] 

Raju Bairishetti commented on LENS-868:
---------------------------------------

Thanks [~sriksun], source release tar does not have node & node_modules with 
the fresh checkout or manual deletion of node & node_modules from lens-ui. 
Running more than once will be bundling node modules to source tar as node & 
node_modules from lens-ui won't be cleaned up with *mvn clean*. 
Seems release *prepare* is just dealing with pom version management and some 
more checks. So, *I am planning to go ahead with [~sriksun]'s suggestion for 
this release.*

Please let me know by 4PM IST today if any one has concerns with the above 
approach.

++[~amareshwari] & [~sriksun]



> Should not bundle node & node_modules (generated files) in source-release 
> archive file
> --------------------------------------------------------------------------------------
>
>                 Key: LENS-868
>                 URL: https://issues.apache.org/jira/browse/LENS-868
>             Project: Apache Lens
>          Issue Type: Bug
>          Components: UI
>            Reporter: Raju Bairishetti
>             Fix For: 2.4
>
>
> We have seen the node & node_modules files from lens-ui are presented in the 
> source-release archive. We should not bundle node & node_modules in the 
> release archive.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to