----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/#review109958 -----------------------------------------------------------
lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java (line 219) <https://reviews.apache.org/r/41039/#comment169701> Lets change the name to decidePriority(), as cost is already calculated as part of estimate lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java (line 69) <https://reviews.apache.org/r/41039/#comment169703> Can you add one more test with both queue and priority set ? - Amareshwari Sriramadasu On Dec. 11, 2015, 1:32 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41039/ > ----------------------------------------------------------- > > (Updated Dec. 11, 2015, 1:32 p.m.) > > > Review request for lens. > > > Bugs: LENS-890 > https://issues.apache.org/jira/browse/LENS-890 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java > 38d58c710a2b917c34cda5de96a36dc49b6f15f0 > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > a84c6792e7b0570c216d30b53066e762a47a4204 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 11efd3c411a10b6506677986609e03f24160b9eb > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > 55f1535191cd0423c850a1309747f81d5490ca12 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > c2208846ddd53adf414bd4bae6898e26ac425c56 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 2f20113a1a30f902a1db4b25d5a78da0126a1b0c > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > b637665e79c46014a7ab8770e0da38d4a9768bd6 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java > bae2e6490aafbfd55c9983c94d9cc892af384f7b > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java > b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java > 55a2eea110f9001c962faede01cef396e8c91b6c > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede > > lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java > 9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 > > Diff: https://reviews.apache.org/r/41039/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
