> On Dec. 15, 2015, 3:31 p.m., Amareshwari Sriramadasu wrote: > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java, > > line 724 > > <https://reviews.apache.org/r/41039/diff/6/?file=1162532#file1162532line724> > > > > Why is this required?
Other test cases are setting this to `true` and `false` whenever needed. In this test case, after this line, it's assumed to be true. All the asserts follow that assumption. So in one test run I found it wasn't true (probably because other tests ran and modified it) and the resultset was an instance of `HiveInMemoryResult`. Hence explicitly setting it here. > On Dec. 15, 2015, 3:31 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java, > > line 216 > > <https://reviews.apache.org/r/41039/diff/6/?file=1162535#file1162535line216> > > > > Doc needs update Updated. > On Dec. 15, 2015, 3:31 p.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 432 > > <https://reviews.apache.org/r/41039/diff/6/?file=1162537#file1162537line432> > > > > Put a comment wrt why it is done again here. Added. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/41039/#review110459 ----------------------------------------------------------- On Dec. 14, 2015, 8:32 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/41039/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2015, 8:32 p.m.) > > > Review request for lens. > > > Bugs: LENS-890 > https://issues.apache.org/jira/browse/LENS-890 > > > Repository: lens > > > Description > ------- > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/util/CommonUtils.java > 38d58c710a2b917c34cda5de96a36dc49b6f15f0 > > lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java > d56e1c7e68ecc741f776db7224877994bcc4489a > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 253cfc4470ae25734d0cc6b05c8382cf69e74773 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > 11efd3c411a10b6506677986609e03f24160b9eb > lens-driver-hive/src/test/resources/priority_tests.data > 98b82ef96068d2cc8d5fd07b4fe7538194cdbcac > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/AbstractLensDriver.java > 55f1535191cd0423c850a1309747f81d5490ca12 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/LensDriver.java > c2208846ddd53adf414bd4bae6898e26ac425c56 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 2f20113a1a30f902a1db4b25d5a78da0126a1b0c > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > b637665e79c46014a7ab8770e0da38d4a9768bd6 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraint.java > bae2e6490aafbfd55c9983c94d9cc892af384f7b > > lens-server-api/src/main/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintFactory.java > b6e6c2f1bd2e4f3c0acdcdaae57dcd812e6bb435 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/TestAbstractQueryContext.java > a37a4c85cf918e62201d6a6dbf4e8b03fa565637 > > lens-server-api/src/test/java/org/apache/lens/server/api/query/constraint/MaxConcurrentDriverQueriesConstraintTest.java > 55a2eea110f9001c962faede01cef396e8c91b6c > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > ffd2d422fd126d7f8acd50014fc4ee9bb3bf5ede > > lens-server/src/test/java/org/apache/lens/server/query/constraint/ThreadSafeEstimatedQueryCollectionTest.java > 9138f8ea2bb0b87bfcd2c9a4770bc732856fa680 > > Diff: https://reviews.apache.org/r/41039/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
