----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47174/#review132403 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/BaseLensService.java (line 295) <https://reviews.apache.org/r/47174/#comment196586> Can we add info log here that this session will be closed later once all the opertaions are over. lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 249) <https://reviews.apache.org/r/47174/#comment196588> The underlying Hive session would have closed after configured no activity timeout even if activeOperationsPresent() = true. Should we factor that in ? lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 609) <https://reviews.apache.org/r/47174/#comment196589> Not sure if we can handle closeSession() and addToActiveQueries() happening parallely. In this case the output will be un predictable. lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java (line 621) <https://reviews.apache.org/r/47174/#comment196587> synchronized (this.activeQueries) needs to be added here too lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java (line 182) <https://reviews.apache.org/r/47174/#comment196591> Do we need to wait for queryHandle1 also ? lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java (line 1798) <https://reviews.apache.org/r/47174/#comment196592> Empty test method . - Puneet Gupta On May 10, 2016, 10:07 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47174/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 10:07 a.m.) > > > Review request for lens. > > > Bugs: LENS-904 > https://issues.apache.org/jira/browse/LENS-904 > > > Repository: lens > > > Description > ------- > > In the current scenario, if the queries are queued from lens side (because of > throttling), then these queries fails on session close. > > > Diffs > ----- > > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > ff3b888038b44dedeb137853c541fb1bb68cc0ef > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 9f8ee7251789cd943e7c6a1091feb44684f248c8 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > b12943e3ea00ef7f24e4db6437d49519fcb499e6 > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 900770b7a31b65490d4e2eaf9ed31e18814c4223 > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > b5d54829ce4c41145eda39702af9f26ed0958fde > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java > 8493d8598adc07609be1ddf4de5734513db7b1eb > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSession.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 62c02809c5ffd8989923a8360e375fd02fa9c406 > > Diff: https://reviews.apache.org/r/47174/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
