> On May 10, 2016, 10:44 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java, > > line 609 > > <https://reviews.apache.org/r/47174/diff/1/?file=1377831#file1377831line609> > > > > Not sure if we can handle closeSession() and addToActiveQueries() > > happening parallely. In this case the output will be un predictable. > > Rajat Khandelwal wrote: > I think currently too we have the same issue. closeSession with > submitQuery will be unpredictable. > > Rajat Khandelwal wrote: > Any suggestions for this? Double checked locking maybe? :P
We can synchronize the two opertaions, but that will just lead to some very specific and un readable code. Since this is a rare corner case, I feel, lets not handle it unless we find a clean way to do it. - Puneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47174/#review132403 ----------------------------------------------------------- On May 31, 2016, 11:12 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47174/ > ----------------------------------------------------------- > > (Updated May 31, 2016, 11:12 a.m.) > > > Review request for lens. > > > Bugs: LENS-904 > https://issues.apache.org/jira/browse/LENS-904 > > > Repository: lens > > > Description > ------- > > In the current scenario, if the queries are queued from lens side (because of > throttling), then these queries fails on session close. > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf > 395d63b87b385607fbb0435bd99ab05b65ca51dd > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > c49b5e860c9c30c54e7a58c629e47ffe60709f62 > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 04d059d65f1ac0ee0f50691cde946d00cbdc57fe > > lens-server-api/src/main/java/org/apache/lens/server/api/SessionValidator.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 3e9f28661132366cd92837265a0a0f7119a24853 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryExecutionService.java > 15ed2229dc21a730140efa5a7297d9c0329cabbc > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > b96cdf0585b285e449dde0e77467f44cbda07d0a > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > 2443fecea303ed963bfcd82071f4ca69ded46227 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 4a6d779a50aa2f0180b0fd35e891dbb2ece770fd > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > 1b3a7c0f6dd9949d313d7c5920d0f0f1dcd18c0b > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > c70689b110462e9623e1e3b5d37af97270c673dc > > lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java > 6c5e52d150bdbbb1075d9150901068bbd3400594 > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > 82a4e15a6e5b12fb5f8ac8fe43076942266d3db5 > lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java > b5d54829ce4c41145eda39702af9f26ed0958fde > lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java > f3d72f4b371020602e5eea0e5c538d5fc1b40de9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 5424404567060009ca27edab814f9b6cf82a594a > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryConstraints.java > 8493d8598adc07609be1ddf4de5734513db7b1eb > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryIndependenceFromSessionClose.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > b6ec42268f9d71897e54beaaead3c2101b5dc06e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryServiceDuplicate.java > 082840300e983b90bc2c43fb8555bf1860fe6bbc > > Diff: https://reviews.apache.org/r/47174/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
