----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47121/#review132808 -----------------------------------------------------------
lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 215) <https://reviews.apache.org/r/47121/#comment197060> we may need to synchronize this method if multiple closes are to be prevented? lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 228) <https://reviews.apache.org/r/47121/#comment197058> When are we expecting this exception? lens-client/src/main/java/org/apache/lens/client/LensConnection.java (line 236) <https://reviews.apache.org/r/47121/#comment197059> Will this code flow be reached or will it stop at if (processingException != null) instead in this case ? - Puneet Gupta On May 10, 2016, 12:46 p.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47121/ > ----------------------------------------------------------- > > (Updated May 10, 2016, 12:46 p.m.) > > > Review request for lens. > > > Bugs: LENS-1010 > https://issues.apache.org/jira/browse/LENS-1010 > > > Repository: lens > > > Description > ------- > > This would allow users to use lens client in try-with-resources clause > without worrying about closing manually. > > https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClient.java > 43da691aff52bc108f99033fac2e8e068ae1c216 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 49518662eb17c1fd24deb26ddd46a36c8826bc5b > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > ff3b888038b44dedeb137853c541fb1bb68cc0ef > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 9f8ee7251789cd943e7c6a1091feb44684f248c8 > lens-server/src/main/java/org/apache/lens/server/LensServices.java > 46bae242bb627b1b542dd37c05baa2b788bd78ed > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7395c832b8cbe6ccde811a8b76fc2e7f97d18c4e > > Diff: https://reviews.apache.org/r/47121/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
