----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/47121/#review134521 -----------------------------------------------------------
Ship it! Ship It! - Puneet Gupta On May 21, 2016, 8:33 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/47121/ > ----------------------------------------------------------- > > (Updated May 21, 2016, 8:33 a.m.) > > > Review request for lens. > > > Bugs: LENS-1010 > https://issues.apache.org/jira/browse/LENS-1010 > > > Repository: lens > > > Description > ------- > > This would allow users to use lens client in try-with-resources clause > without worrying about closing manually. > > https://docs.oracle.com/javase/tutorial/essential/exceptions/tryResourceClose.html > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClient.java > 480b6f8e5b7d98f10e5315beb41955597acbd4c3 > lens-client/src/main/java/org/apache/lens/client/LensConnection.java > 49518662eb17c1fd24deb26ddd46a36c8826bc5b > lens-client/src/test/java/org/apache/lens/client/TestLensClient.java > 5cf7417eef469e9f1bfbd35fc0ecfbbe64733c8a > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 9f8ee7251789cd943e7c6a1091feb44684f248c8 > lens-server/src/main/java/org/apache/lens/server/LensServices.java > 46bae242bb627b1b542dd37c05baa2b788bd78ed > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 6f10d58ee856e264dcbc3dcba455138f9cb8110b > lens-server/src/test/java/org/apache/lens/server/TestServerMode.java > fce6e5f2c2d09a4d76fdcb752107b98937791275 > src/site/apt/user/olap-query-conf.apt > 8533ca7b14c12ca8a596f89af518000238e937cd > > Diff: https://reviews.apache.org/r/47121/diff/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
