----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49770/#review141641 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (line 34) <https://reviews.apache.org/r/49770/#comment206988> Can the first and/or the third arguments converted to take `Service` instead of `ServiceImpl`? lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (line 72) <https://reviews.apache.org/r/49770/#comment206989> Should be job submitter's login lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java (line 118) <https://reviews.apache.org/r/49770/#comment206990> Mark failed here too? lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java (line 55) <https://reviews.apache.org/r/49770/#comment206991> might need to add one more case for `CLOSED` state. lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java (line 57) <https://reviews.apache.org/r/49770/#comment206993> `fromString(x.toString)` would be slightly slower than `new SchedulerJobHandle(UUID.randomUUID())`. - Rajat Khandelwal On July 8, 2016, 1:05 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49770/ > ----------------------------------------------------------- > > (Updated July 8, 2016, 1:05 a.m.) > > > Review request for lens. > > > Bugs: LENS-128 > https://issues.apache.org/jira/browse/LENS-128 > > > Repository: lens > > > Description > ------- > > Implementaion of core scheduler: > TODO: > 1. Test cases. > 2. Open session with the user. > 3. Saved Query. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java > 7d06689 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java > 8158576 > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > 3ca7eb9 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > d0af876 > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java > 39c4d98 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java > bf99fde > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > 3952671 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > a4cdd83 > > lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java > 31783ad > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > e77c7fa > > lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java > d76a586 > > lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerServiceTest.java > PRE-CREATION > > Diff: https://reviews.apache.org/r/49770/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
