> On July 11, 2016, 12:24 p.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java, > > line 55 > > <https://reviews.apache.org/r/49770/diff/1/?file=1439019#file1439019line55> > > > > might need to add one more case for `CLOSED` state. > > Lavkesh Lahngir wrote: > Do yo think there is a need to check CLOSED status ?
In case CLOSED comes here, we don't want it to mark it as failed. You might have to check through test cases whether CLOSED event comes here or not. - Rajat ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/49770/#review141641 ----------------------------------------------------------- On July 15, 2016, 2:42 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/49770/ > ----------------------------------------------------------- > > (Updated July 15, 2016, 2:42 p.m.) > > > Review request for lens. > > > Bugs: LENS-128 > https://issues.apache.org/jira/browse/LENS-128 > > > Repository: lens > > > Description > ------- > > Implementaion of core scheduler: > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInfo.java > 7d06689 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceInfo.java > 8158576 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceRun.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/parse/TimerangeResolver.java > 33ec9d9 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > bd9b1ab > > lens-server-api/src/main/java/org/apache/lens/server/api/events/SchedulerAlarmEvent.java > 3ca7eb9 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > d0af876 > > lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobInstanceState.java > PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/scheduler/SchedulerJobState.java > PRE-CREATION > lens-server/src/main/java/org/apache/lens/server/BaseLensService.java > 74bc0be > lens-server/src/main/java/org/apache/lens/server/LensServices.java 7618669 > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java > 39c4d98 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerDAO.java > bf99fde > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerQueryEventListener.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > 3952671 > > lens-server/src/main/java/org/apache/lens/server/scheduler/notification/services/AlarmService.java > a4cdd83 > > lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobInstanceState.java > 95057e4 > > lens-server/src/main/java/org/apache/lens/server/scheduler/state/SchedulerJobState.java > d21cd05 > > lens-server/src/main/java/org/apache/lens/server/scheduler/util/UtilityMethods.java > 31783ad > > lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java > e77c7fa > > lens-server/src/test/java/org/apache/lens/server/scheduler/SchedulerDAOTest.java > d76a586 > > lens-server/src/test/java/org/apache/lens/server/scheduler/TestSchedulerServiceImpl.java > PRE-CREATION > > lens-server/src/test/java/org/apache/lens/server/scheduler/notification/services/AlarmServiceTest.java > 06883ae > > Diff: https://reviews.apache.org/r/49770/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
