----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51206/#review146336 -----------------------------------------------------------
lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java (line 69) <https://reviews.apache.org/r/51206/#comment212710> this block should also be accessed in case `action == 'schedule'`. Also, can we throw `LensException` in the `else` block instead of `BadRequestException`? You can look at QueryServiceResource.checkAndGetQuerySubmitOperation for reference code. lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java (line 151) <https://reviews.apache.org/r/51206/#comment212711> Let's try to convert this to `LensException` too. lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java (line 197) <https://reviews.apache.org/r/51206/#comment212712> ^ lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java (line 185) <https://reviews.apache.org/r/51206/#comment212714> is it always returning `true` now? If yes, then can the return type can be `void`, if the caller is not using the return type? lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java (line 240) <https://reviews.apache.org/r/51206/#comment212715> Same as above. If the architecture is changed from `true-false` based to `true-exception` based, then we should use `void-exception` design. lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java (lines 258 - 282) <https://reviews.apache.org/r/51206/#comment212716> ^ lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java (line 297) <https://reviews.apache.org/r/51206/#comment212717> ^Same as above - Rajat Khandelwal On Aug. 22, 2016, 3:02 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51206/ > ----------------------------------------------------------- > > (Updated Aug. 22, 2016, 3:02 p.m.) > > > Review request for lens. > > > Bugs: LENS-1279 > https://issues.apache.org/jira/browse/LENS-1279 > > > Repository: lens > > > Description > ------- > > Adding Scheduler Specific error codes and messaegs to make API response more > readable. > > > Diffs > ----- > > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobHandle.java > 2e3aab8 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceHandle.java > 129afe1 > lens-api/src/main/resources/lens-errors.conf 537b458 > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > 8e1606e > > lens-server/src/main/java/org/apache/lens/server/error/LensSchedulerErrorCode.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java > 2009a20 > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java > 7a0b485 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java > d1d4a68 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > 74b337c > > Diff: https://reviews.apache.org/r/51206/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
