> On Aug. 23, 2016, 7:34 a.m., Rajat Khandelwal wrote: > > lens-server/src/main/java/org/apache/lens/server/error/UnSupportedOpException.java, > > line 34 > > <https://reviews.apache.org/r/51206/diff/6/?file=1481683#file1481683line34> > > > > Should this be `UNSUPPORTED_OPERATION` instead of `query submit > > operation`?
Yes. I will change the enum name. - Lavkesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51206/#review146483 ----------------------------------------------------------- On Aug. 23, 2016, 5:45 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51206/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2016, 5:45 a.m.) > > > Review request for lens. > > > Bugs: LENS-1279 > https://issues.apache.org/jira/browse/LENS-1279 > > > Repository: lens > > > Description > ------- > > Adding Scheduler Specific error codes and messaegs to make API response more > readable. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/SupportedOperations.java > PRE-CREATION > > lens-api/src/main/java/org/apache/lens/api/query/SupportedQuerySubmitOperations.java > 8fcf608 > lens-api/src/main/java/org/apache/lens/api/result/LensAPIResult.java > e940b97 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobHandle.java > 2e3aab8 > > lens-api/src/main/java/org/apache/lens/api/scheduler/SchedulerJobInstanceHandle.java > 129afe1 > lens-api/src/main/resources/lens-errors.conf 537b458 > > lens-api/src/test/java/org/apache/lens/api/query/SupportedOperationsTest.java > PRE-CREATION > > lens-api/src/test/java/org/apache/lens/api/query/SupportedQuerySubmitOperationsTest.java > 730904b > > lens-server-api/src/main/java/org/apache/lens/server/api/scheduler/SchedulerService.java > 8e1606e > > lens-server/src/main/java/org/apache/lens/server/error/LensSchedulerErrorCode.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/error/UnSupportedOpException.java > PRE-CREATION > > lens-server/src/main/java/org/apache/lens/server/error/UnSupportedQuerySubmitOpException.java > 9e600c8 > > lens-server/src/main/java/org/apache/lens/server/query/QueryServiceResource.java > 7d8d300 > > lens-server/src/main/java/org/apache/lens/server/scheduler/AlarmService.java > 2009a20 > > lens-server/src/main/java/org/apache/lens/server/scheduler/ScheduleResource.java > 7a0b485 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerEventListener.java > d1d4a68 > > lens-server/src/main/java/org/apache/lens/server/scheduler/SchedulerServiceImpl.java > 74b337c > > Diff: https://reviews.apache.org/r/51206/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
