----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52514/#review154865 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 523) <https://reviews.apache.org/r/52514/#comment224621> Measures are getting added, by iterating over queried phrases below. But empty check is happening here. Populating measures should be moved up. lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 532) <https://reviews.apache.org/r/52514/#comment224625> Can you cross check context.getQueriedMsrs() is actually resolving expression fields as well ? I'm not fully sure. lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (lines 559 - 560) <https://reviews.apache.org/r/52514/#comment224622> Why do you need this formatter? And why is formatting done upto hours? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 590) <https://reviews.apache.org/r/52514/#comment224623> Shall we rename variable to incompletePartition, instead of partitionCompleteness ? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (line 593) <https://reviews.apache.org/r/52514/#comment224624> Instead of measureFromTag should be we put actual queried phrase column here ? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java (lines 597 - 599) <https://reviews.apache.org/r/52514/#comment224626> Should be moved to outer while loop and should be moved inside the check for isFactDataIncomplete flag for removing there. lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 939) <https://reviews.apache.org/r/52514/#comment224627> Why didn't the query fail here ? If the test is to check no failure on partial data, can you update testname and comment above. lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java (line 973) <https://reviews.apache.org/r/52514/#comment224628> Can you share the reason being shown up, as a comment? - Amareshwari Sriramadasu On Nov. 3, 2016, 11:13 a.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52514/ > ----------------------------------------------------------- > > (Updated Nov. 3, 2016, 11:13 a.m.) > > > Review request for lens. > > > Bugs: LENS-1333 > https://issues.apache.org/jira/browse/LENS-1333 > > > Repository: lens > > > Description > ------- > > Though lens has partition registration being done whenever data is available, > there is no guarantee the partition registered is complete. There can be > different ways to know if the data is complete for partition. One option > could be to have a partition property saying whether it is complete or not. > Other could be to do a http call to another hosted service and more. > > Proposal here is to add an interface for DataCompletenessChecker and do the > check while resolving partitions. > > Here are some of the capabilities we would like to add in Lens : > # Lens will check partition existence first, if it exists, then check the > completeness percentage. If the completeness percentage is less than a > configured threshold (default should be 98, 99 or even 100), Lens will fail > the query. > # Lens's accept query on partial data will accept on incomplete data as well. > # Lens will also option to override the completeness percentage threshold > value at query level > # Lens will still have look ahead capability of daily being incomplete, then > it will union with hourly. > # If same measure is there in two different facts , Lens will we pick the one > with higher availability. > # In case of completeness percentage threshold missed, Lens will respond back > with available percentage. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > fb958c3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e14c43f > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 4585ef7 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 5dc9dc9 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 78fb21d > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > f20f105 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultChecker.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 13f1aa4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > db26718 > lens-cube/src/main/resources/olap-query-conf.xml 0c888ca > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 0c43cb5 > > lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java > 7afa32e > > lens-cube/src/test/java/org/apache/lens/cube/parse/MockCompletenessChecker.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > f6cec1b > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > b90d4d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 0aa31f4 > lens-server/src/main/resources/lenssession-default.xml 9a8f9da > src/site/apt/admin/session-config.apt d480f88 > src/site/apt/user/olap-query-conf.apt ce35ec4 > > Diff: https://reviews.apache.org/r/52514/diff/ > > > Testing > ------- > > > Thanks, > > Narayan Periwal > >
