> On Nov. 9, 2016, 11:20 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java, > > line 155 > > <https://reviews.apache.org/r/52514/diff/5/?file=1556639#file1556639line155> > > > > should we add null check for cause.getIncompletePartitions() ?
Yes. I think we should add the null check. > On Nov. 9, 2016, 11:20 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > line 35 > > <https://reviews.apache.org/r/52514/diff/5/?file=1556643#file1556643line35> > > > > this would result in checkstyle error. I ran mvn clean install and there was no checkstyle error. Will verify this again. > On Nov. 9, 2016, 11:20 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java, > > line 553 > > <https://reviews.apache.org/r/52514/diff/5/?file=1556643#file1556643line553> > > > > Why are we breaking after processing one measure? Shouldnt we process > > all measures in the expression? This is done to associate the expression with one of the dataCompletenessTag for the measures. So, even if the expression is composed of measures with different dataCompletenessTags, we will be determining the dataCompleteness from one of the measure and this expression is grouped with the other queried measures that have the same dataCompletenessTag. - Narayan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52514/#review155418 ----------------------------------------------------------- On Nov. 8, 2016, 1:11 p.m., Narayan Periwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52514/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2016, 1:11 p.m.) > > > Review request for lens. > > > Bugs: LENS-1333 > https://issues.apache.org/jira/browse/LENS-1333 > > > Repository: lens > > > Description > ------- > > Though lens has partition registration being done whenever data is available, > there is no guarantee the partition registered is complete. There can be > different ways to know if the data is complete for partition. One option > could be to have a partition property saying whether it is complete or not. > Other could be to do a http call to another hosted service and more. > > Proposal here is to add an interface for DataCompletenessChecker and do the > check while resolving partitions. > > Here are some of the capabilities we would like to add in Lens : > # Lens will check partition existence first, if it exists, then check the > completeness percentage. If the completeness percentage is less than a > configured threshold (default should be 98, 99 or even 100), Lens will fail > the query. > # Lens's accept query on partial data will accept on incomplete data as well. > # Lens will also option to override the completeness percentage threshold > value at query level > # Lens will still have look ahead capability of daily being incomplete, then > it will union with hourly. > # If same measure is there in two different facts , Lens will we pick the one > with higher availability. > # In case of completeness percentage threshold missed, Lens will respond back > with available percentage. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > fb958c3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > e14c43f > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 4585ef7 > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateFact.java > 5dc9dc9 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > 78fb21d > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > f20f105 > lens-cube/src/main/java/org/apache/lens/cube/parse/DefaultChecker.java > PRE-CREATION > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 13f1aa4 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > db26718 > lens-cube/src/main/resources/olap-query-conf.xml 0c888ca > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 0c43cb5 > > lens-cube/src/test/java/org/apache/lens/cube/parse/FieldsCannotBeQueriedTogetherTest.java > 7afa32e > > lens-cube/src/test/java/org/apache/lens/cube/parse/MockCompletenessChecker.java > PRE-CREATION > lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java > f6cec1b > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > b90d4d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > 0aa31f4 > lens-server/src/main/resources/lenssession-default.xml 9a8f9da > src/site/apt/admin/session-config.apt d480f88 > src/site/apt/user/olap-query-conf.apt ce35ec4 > > Diff: https://reviews.apache.org/r/52514/diff/ > > > Testing > ------- > > > Thanks, > > Narayan Periwal > >
