----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/#review166126 -----------------------------------------------------------
1. Can you commnet on https://github.com/sushilmohanty/incubator-lens/pull/4 and metion which all comments are resolved 2. Can you run test cases for lens-cube lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java (line 257) <https://reviews.apache.org/r/56858/#comment238024> Comment is redundant ? lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java <https://reviews.apache.org/r/56858/#comment238027> Removed ? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java <https://reviews.apache.org/r/56858/#comment238028> Removed ? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java <https://reviews.apache.org/r/56858/#comment238029> Removed ? - Puneet Gupta On Feb. 20, 2017, 5:39 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56858/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2017, 5:39 p.m.) > > > Review request for lens. > > > Bugs: LENS-1391 > https://issues.apache.org/jira/browse/LENS-1391 > > > Repository: lens > > > Description > ------- > > MaxCoveringFactResolver and LeastPartitionResolver review comments > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > c7f2047b57ebc26244891d9bc48ad18ab0176fdd > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > 153df245cd2b79ee29991f98df36f57e4e029d2f > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 4664cde1786c2e6217a0d7aa7a26d1cc248bf532 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fca86ec88b1dd0507d21ca1b414dcc6fb68317e3 > > Diff: https://reviews.apache.org/r/56858/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
