----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56858/#review166167 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java (line 122) <https://reviews.apache.org/r/56858/#comment238052> But null does not make sense. We should pass the incomplete partitions. Lets have an online discussion on this if you feel otherwise. cubeql.addCandidatePruningMsg() actually adds the message at StorageCandidate Level . - Puneet Gupta On Feb. 21, 2017, 12:12 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56858/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 12:12 p.m.) > > > Review request for lens. > > > Bugs: LENS-1391 > https://issues.apache.org/jira/browse/LENS-1391 > > > Repository: lens > > > Description > ------- > > MaxCoveringFactResolver and LeastPartitionResolver review comments > > > Diffs > ----- > > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTablePruneCause.java > c7f2047 > > lens-cube/src/main/java/org/apache/lens/cube/parse/LeastPartitionResolver.java > 153df24 > > lens-cube/src/main/java/org/apache/lens/cube/parse/MaxCoveringFactResolver.java > 4664cde > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fca86ec > > Diff: https://reviews.apache.org/r/56858/diff/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
