----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170019 -----------------------------------------------------------
Can you also add one example xml file for virtual fact in examples? lens-api/src/main/resources/cube-0.1.xsd Lines 172 (patched) <https://reviews.apache.org/r/57908/#comment242750> we need to add `filter` somewhere inside the fact definition. lens-api/src/main/resources/cube-0.1.xsd Lines 184 (patched) <https://reviews.apache.org/r/57908/#comment242749> By extending, we'll have to specify everything that we specify for fact table, which would mean columns would need to be provided. I don't think extension is something we need to use in this case. - Rajat Khandelwal On March 24, 2017, 5:45 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57908/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 5:45 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Xsd for virtual fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 060eb43 > > > Diff: https://reviews.apache.org/r/57908/diff/2/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
