> On March 24, 2017, 3:59 p.m., Rajat Khandelwal wrote: > > Can you also add one example xml file for virtual fact in examples?
Will do > On March 24, 2017, 3:59 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/cube-0.1.xsd > > Lines 172 (patched) > > <https://reviews.apache.org/r/57908/diff/2/?file=1673842#file1673842line172> > > > > we need to add `filter` somewhere inside the fact definition. filter will be added as a property. I will add it in the sample xml > On March 24, 2017, 3:59 p.m., Rajat Khandelwal wrote: > > lens-api/src/main/resources/cube-0.1.xsd > > Lines 184 (patched) > > <https://reviews.apache.org/r/57908/diff/2/?file=1673842#file1673842line184> > > > > By extending, we'll have to specify everything that we specify for fact > > table, which would mean columns would need to be provided. I don't think > > extension is something we need to use in this case. Will do. - Rajitha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170019 ----------------------------------------------------------- On March 24, 2017, 12:15 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57908/ > ----------------------------------------------------------- > > (Updated March 24, 2017, 12:15 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Xsd for virtual fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 060eb43 > > > Diff: https://reviews.apache.org/r/57908/diff/2/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
