> On March 30, 2017, 5:26 a.m., Amareshwari Sriramadasu wrote: > > lens-examples/src/main/resources/virtualfact1.xml > > Lines 25-26 (patched) > > <https://reviews.apache.org/r/57908/diff/5/?file=1677439#file1677439line25> > > > > Should these be fields on cube or fields on fact? If fields from fact, > > then expresssions or join chains defined in cube, may not be getting used. > > I feel these should be from cube fields, to give users more control.
Will we validate this filter ? as in the fileds used in the filter are valid or not. If we are not validating the filter and just using it it the last phase (after candidate is picked and we are about to write the query for it) , user should be able to specify any fileds in the filter (cueb,fact,etc). Also the filter has no time specific validity. Say filter1 for time range 1 and filter2 for time range 2. We can think about this further. - Puneet ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170530 ----------------------------------------------------------- On March 28, 2017, 7:22 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57908/ > ----------------------------------------------------------- > > (Updated March 28, 2017, 7:22 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Xsd for virtual fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 060eb43 > lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/57908/diff/5/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
