----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57908/#review170712 -----------------------------------------------------------
lens-api/src/main/resources/cube-0.1.xsd Lines 190 (patched) <https://reviews.apache.org/r/57908/#comment243601> Having filter on a virtual fact does not make sense to me. As having is usually associated with a query and it is over aggregates. - Amareshwari Sriramadasu On March 28, 2017, 7:22 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57908/ > ----------------------------------------------------------- > > (Updated March 28, 2017, 7:22 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Xsd for virtual fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 060eb43 > lens-examples/src/main/resources/virtualfact1.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/57908/diff/5/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
