> On April 21, 2017, 11:49 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > > Lines 68 (patched) > > <https://reviews.apache.org/r/58604/diff/2/?file=1697178#file1697178line68> > > > > Should not be going into Cube errors, should be moved to > > LensServerErrorCode. > > > > And accordingly change error code and position in lens-errors
sure. > On April 21, 2017, 11:49 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > > Lines 1988 (patched) > > <https://reviews.apache.org/r/58604/diff/2/?file=1697181#file1697181line2100> > > > > why is it only 10, when 20 threads are launched? Typo. > On April 21, 2017, 11:49 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > > Lines 1989 (patched) > > <https://reviews.apache.org/r/58604/diff/2/?file=1697181#file1697181line2101> > > > > Should we be joining for all vs interrupt them and join? Interrupting > > would reduce test time. Only few threads will go to FailQueryDriver. Interrupting might not simulate the rejection error. > On April 21, 2017, 11:49 a.m., Amareshwari Sriramadasu wrote: > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > > Lines 1991 (patched) > > <https://reviews.apache.org/r/58604/diff/2/?file=1697181#file1697181line2103> > > > > Add assert for howmany failed as well. number of failures are not totally deterministic. - Lavkesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/#review172628 ----------------------------------------------------------- On April 21, 2017, 11:40 a.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58604/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 11:40 a.m.) > > > Review request for lens. > > > Bugs: LENS-1413 > https://issues.apache.org/jira/browse/LENS-1413 > > > Repository: lens > > > Description > ------- > > 1. Cancel estimates for other drivers when the estimate pool queue is full. > 2. Return the appropriate error message > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf 236d678 > lens-cube/src/main/java/org/apache/lens/cube/error/LensCubeErrorCode.java > babe3de > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c6fbeda > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 7e9133e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7d8c977 > lens-server/src/test/resources/lens-site.xml 334a9c4 > > > Diff: https://reviews.apache.org/r/58604/diff/2/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
