> On April 21, 2017, 9:34 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > > Lines 1716 (patched) > > <https://reviews.apache.org/r/58604/diff/1/?file=1697059#file1697059line1716> > > > > Not sure if logging the driver name makes sense. Also Should we log > > this as error or warning is debatable ?
hmm. I guess logging does not hurt.. we can see which ones were rejected and which ones were cancelled. > On April 21, 2017, 9:34 a.m., Puneet Gupta wrote: > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > > Lines 1722 (patched) > > <https://reviews.apache.org/r/58604/diff/1/?file=1697059#file1697059line1722> > > > > can we use for(RewriteEstimateRunnable r : runnables) instead ? uh. In this loop we are fetching from two lists. - Lavkesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58604/#review172619 ----------------------------------------------------------- On April 21, 2017, 12:10 p.m., Lavkesh Lahngir wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58604/ > ----------------------------------------------------------- > > (Updated April 21, 2017, 12:10 p.m.) > > > Review request for lens. > > > Bugs: LENS-1413 > https://issues.apache.org/jira/browse/LENS-1413 > > > Repository: lens > > > Description > ------- > > 1. Cancel estimates for other drivers when the estimate pool queue is full. > 2. Return the appropriate error message > > > Diffs > ----- > > lens-api/src/main/resources/lens-errors.conf 236d678 > > lens-server/src/main/java/org/apache/lens/server/error/LensServerErrorCode.java > 14a31e2 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > c6fbeda > > lens-server/src/test/java/org/apache/lens/server/common/FailingQueryDriver.java > 7e9133e > > lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java > 7d8c977 > lens-server/src/test/resources/lens-site.xml 334a9c4 > > > Diff: https://reviews.apache.org/r/58604/diff/3/ > > > Testing > ------- > > > Thanks, > > Lavkesh Lahngir > >
