----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review173559 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java Lines 386 (patched) <https://reviews.apache.org/r/58796/#comment246550> Why are all source fact properties getting copied for virtual fact? I feel, we shouldn't be doing this. lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java Lines 27 (patched) <https://reviews.apache.org/r/58796/#comment246552> Can we avoid extends of the CubeFactTable, as the class is already composing sourceFactTable ? lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java Lines 32 (patched) <https://reviews.apache.org/r/58796/#comment246554> Not sure how are we passing sourceHiveTable for the constructor here? We need to actually store the source fact table as a property name underlying Hive table. lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java Lines 1268 (patched) <https://reviews.apache.org/r/58796/#comment246555> Can we create virtual fact belonging to a different cube than source fact? lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java Lines 432 (patched) <https://reviews.apache.org/r/58796/#comment246556> Can we name the param vFact ? Applies to all methods. - Amareshwari Sriramadasu On April 28, 2017, 10:23 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > ----------------------------------------------------------- > > (Updated April 28, 2017, 10:23 a.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > ------- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 68ccc13 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeTableType.java > 6dd35b3 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > 3a17499 > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 6d32d23 > > > Diff: https://reviews.apache.org/r/58796/diff/2/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s] > [INFO] Lens .............................................. SUCCESS [3.449s] > [INFO] Lens API .......................................... SUCCESS [23.572s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.051s] > [INFO] Lens Cube ......................................... SUCCESS [5:41.995s] > [INFO] Lens DB storage ................................... SUCCESS [17.013s] > [INFO] Lens Query Library ................................ SUCCESS [13.632s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s] > [INFO] Lens Server ....................................... SUCCESS > [16:38.220s] > [INFO] Lens client ....................................... SUCCESS [1:25.658s] > [INFO] Lens CLI .......................................... SUCCESS [1:16.332s] > [INFO] Lens Examples ..................................... SUCCESS [8.432s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s] > [INFO] Lens Distribution ................................. SUCCESS [9.499s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s] > [INFO] Lens Regression ................................... SUCCESS [12.136s] > [INFO] Lens UI ........................................... SUCCESS [32.999s] > [INFO] Lens Contrib ...................................... SUCCESS [0.358s] > [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s] > [INFO] Lens Python Client ................................ SUCCESS [0.366s] > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajitha R > >
