> On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > > Lines 229-234 (patched) > > <https://reviews.apache.org/r/58796/diff/3/?file=1709963#file1709963line229> > > > > Can we move this method to MetastoreUtil or even remove it and use the > > onliner 'props.get(MetastoreUtil.getFactCubeNameKey(factName));' from the > > caller itself?
done. > On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > > Lines 98 (patched) > > <https://reviews.apache.org/r/58796/diff/3/?file=1709965#file1709965line108> > > > > Why is this mapping required? removed this > On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > > Line 136 (original), 134 (patched) > > <https://reviews.apache.org/r/58796/diff/3/?file=1709965#file1709965line144> > > > > Does extractStorageName has to work on FactTable interface as well? As discussed, yes. > On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > > Line 2195 (original), 2326 (patched) > > <https://reviews.apache.org/r/58796/diff/3/?file=1709965#file1709965line2336> > > > > Shall we return all facts here both direct facts and virtual facts? > > > > We can have one more method which takes a boolean to include virtual > > facts or not? done > On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > > Lines 29 (patched) > > <https://reviews.apache.org/r/58796/diff/3/?file=1709968#file1709968line29> > > > > remvoe author tags. done > On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > > Lines 31 (patched) > > <https://reviews.apache.org/r/58796/diff/3/?file=1709968#file1709968line31> > > > > Can we add javadoc for all the methods in interface? done > On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > > Lines 55 (patched) > > <https://reviews.apache.org/r/58796/diff/3/?file=1709968#file1709968line55> > > > > This looks more a util method and shouldnt sit in interface. done > On May 9, 2017, 8:36 a.m., Amareshwari Sriramadasu wrote: > > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > > Lines 725 (patched) > > <https://reviews.apache.org/r/58796/diff/3/?file=1709969#file1709969line725> > > > > Why are we doing this copy of properties? removed - Rajitha ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58796/#review174275 ----------------------------------------------------------- On May 15, 2017, 1:38 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58796/ > ----------------------------------------------------------- > > (Updated May 15, 2017, 1:38 p.m.) > > > Review request for lens, Rajat Khandelwal and Puneet Gupta. > > > Repository: lens > > > Description > ------- > > CRUD changes and Unit test cases for Virtual Fact > > > Diffs > ----- > > lens-api/src/main/resources/cube-0.1.xsd 8158e6d > > lens-cube/src/main/java/org/apache/lens/cube/metadata/AbstractCubeTable.java > 67aaff8 > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeFactTable.java > 88bc1fc > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeMetastoreClient.java > b5c4c89 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/FactTable.java > PRE-CREATION > lens-cube/src/main/java/org/apache/lens/cube/metadata/JAXBUtils.java > e1e3d16 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreConstants.java > 88500fd > lens-cube/src/main/java/org/apache/lens/cube/metadata/MetastoreUtil.java > 40f766b > lens-cube/src/main/java/org/apache/lens/cube/metadata/Segmentation.java > 1e3cef3 > > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateTableResolver.java > a8d6fbd > lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateUtil.java > 6ba46d6 > lens-cube/src/main/java/org/apache/lens/cube/parse/DimHQLContext.java > 43510dd > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > 1e54f13 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidateHQLContext.java > 730b802 > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageTableResolver.java > 291712b > > lens-cube/src/test/java/org/apache/lens/cube/metadata/CubeFactTableTest.java > 42e32cb > > lens-cube/src/test/java/org/apache/lens/cube/metadata/TestCubeMetastoreClient.java > a76ef13 > lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java > 2f300d3 > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > 7d1f80d > lens-cube/src/test/resources/schema/cubes/base/virtualcube.xml PRE-CREATION > lens-cube/src/test/resources/schema/facts/virtualfact.xml PRE-CREATION > > lens-server-api/src/main/java/org/apache/lens/server/api/metastore/CubeMetastoreService.java > 28b9d22 > > lens-server/src/main/java/org/apache/lens/server/metastore/CubeMetastoreServiceImpl.java > 194b380 > > lens-server/src/main/java/org/apache/lens/server/metastore/MetastoreResource.java > 7451aa9 > > lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java > 6d32d23 > > > Diff: https://reviews.apache.org/r/58796/diff/4/ > > > Testing > ------- > > [INFO] > ------------------------------------------------------------------------ > [INFO] Reactor Summary: > [INFO] > [INFO] Lens Checkstyle Rules ............................. SUCCESS [1.467s] > [INFO] Lens .............................................. SUCCESS [3.449s] > [INFO] Lens API .......................................... SUCCESS [23.572s] > [INFO] Lens API for server and extensions ................ SUCCESS [20.051s] > [INFO] Lens Cube ......................................... SUCCESS [5:41.995s] > [INFO] Lens DB storage ................................... SUCCESS [17.013s] > [INFO] Lens Query Library ................................ SUCCESS [13.632s] > [INFO] Lens Hive Driver .................................. SUCCESS [1:16.131s] > [INFO] Lens Driver for JDBC .............................. SUCCESS [48.127s] > [INFO] Lens Elastic Search Driver ........................ SUCCESS [21.542s] > [INFO] Lens Server ....................................... SUCCESS > [16:38.220s] > [INFO] Lens client ....................................... SUCCESS [1:25.658s] > [INFO] Lens CLI .......................................... SUCCESS [1:16.332s] > [INFO] Lens Examples ..................................... SUCCESS [8.432s] > [INFO] Lens Ship Jars to Distributed Cache ............... SUCCESS [0.766s] > [INFO] Lens Distribution ................................. SUCCESS [9.499s] > [INFO] Lens ML Lib ....................................... SUCCESS [1:02.656s] > [INFO] Lens ML Ext Distribution .......................... SUCCESS [2.552s] > [INFO] Lens Regression ................................... SUCCESS [12.136s] > [INFO] Lens UI ........................................... SUCCESS [32.999s] > [INFO] Lens Contrib ...................................... SUCCESS [0.358s] > [INFO] Lens Contributed Clients .......................... SUCCESS [0.360s] > [INFO] Lens Python Client ................................ SUCCESS [0.366s] > [INFO] > ------------------------------------------------------------------------ > > > Thanks, > > Rajitha R > >
