----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58986/#review174011 -----------------------------------------------------------
lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java Lines 67 (patched) <https://reviews.apache.org/r/58986/#comment247108> Is this required ? lens-regression/src/main/java/org/apache/lens/regression/util/Util.java Lines 107 (patched) <https://reviews.apache.org/r/58986/#comment247105> Is this needed ? - Puneet Gupta On May 5, 2017, 8:22 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58986/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 8:22 a.m.) > > > Review request for lens. > > > Bugs: LENS-1418 > https://issues.apache.org/jira/browse/LENS-1418 > > > Repository: lens > > > Description > ------- > > Using one lens client to fire two queries in two threads results in > discrepencies. LensClient has a {{Map<QueryHandle, LensStatement>}} and also > has a cached instance of {{LensStatement}}. When two threads fire queries, > both use the same statement object. {{LensStatement}} object in turn caches > {{LensQuery}} Object. So whichever thread fired query last is the last one to > set lens query inside statement causing > {{LensClient.getStatement().getQuery()}} to return that query object for all > threads. > > > Diffs > ----- > > lens-client/src/main/java/org/apache/lens/client/LensClient.java > e9367988fa780ed0ca3e2a2698226e43c011777f > > lens-regression/src/main/java/org/apache/lens/regression/core/helpers/ServiceManagerHelper.java > 2370f3e8e2ce1dc4fa95cbce716355a7cf75a2d8 > lens-regression/src/main/java/org/apache/lens/regression/util/Util.java > 80ba912f43de4686f27732c54647a715f0514387 > src/site/apt/user/cli.apt caffda7d60f3001883e4922096807fe07a939bab > > > Diff: https://reviews.apache.org/r/58986/diff/4/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
