----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58986/#review174017 -----------------------------------------------------------
Ship it! Ship It! - Puneet Gupta On May 5, 2017, 11:17 a.m., Rajat Khandelwal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58986/ > ----------------------------------------------------------- > > (Updated May 5, 2017, 11:17 a.m.) > > > Review request for lens. > > > Bugs: LENS-1418 > https://issues.apache.org/jira/browse/LENS-1418 > > > Repository: lens > > > Description > ------- > > Using one lens client to fire two queries in two threads results in > discrepencies. LensClient has a {{Map<QueryHandle, LensStatement>}} and also > has a cached instance of {{LensStatement}}. When two threads fire queries, > both use the same statement object. {{LensStatement}} object in turn caches > {{LensQuery}} Object. So whichever thread fired query last is the last one to > set lens query inside statement causing > {{LensClient.getStatement().getQuery()}} to return that query object for all > threads. > > > Diffs > ----- > > lens-cli/src/test/java/org/apache/lens/cli/TestLensQueryCommands.java > e1eaae5bde4718dc91982506a6b8619ff9872225 > lens-client/src/main/java/org/apache/lens/client/LensClient.java > e9367988fa780ed0ca3e2a2698226e43c011777f > src/site/apt/user/cli.apt caffda7d60f3001883e4922096807fe07a939bab > > > Diff: https://reviews.apache.org/r/58986/diff/6/ > > > Testing > ------- > > > Thanks, > > Rajat Khandelwal > >
