-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62060/
-----------------------------------------------------------
(Updated Sept. 4, 2017, 4:55 p.m.)
Review request for lens.
Bugs: LENS-1471
https://issues.apache.org/jira/browse/LENS-1471
Repository: lens
Description
-------
The issue is in Join candidates of the kind {{Join\[Union\[a,b\];
Union\[a,c\]\]}}. If the instance of {{a}} is shared in different trees of a
JoinCandidate, the rewritten query will be wrong. JoinCandidate's children set
exclusive measure phrase indices, and that is done via truncate method of list.
So let's say union1 is answering {{\[0,1\]}} measures and union2 is answering
{{\[2,3\]}} measures, and since {{\[0,1,2,3\].retain(\[0,1\]).retain(\[2,3\])
== \[\]}}, it ends up answering no measures at all
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/CandidateCoveringSetsResolver.java
1cff4a424fddb7e124531837ce29a5d8ed97d49c
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java
27835b371c51579ae35d526fc6245f6cf5c7ffb4
lens-cube/src/main/java/org/apache/lens/cube/parse/UnionCandidate.java
510ea0c5b1edf1dd60b5380ba3b2a47844ed2219
Diff: https://reviews.apache.org/r/62060/diff/2/
Changes: https://reviews.apache.org/r/62060/diff/1-2/
Testing
-------
Thanks,
Rajat Khandelwal
