----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62773/#review187521 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java Line 332 (original), 338 (patched) <https://reviews.apache.org/r/62773/#comment264531> Can we extraxt this code into a separate method getSourceFactTableProperties(fact) - Puneet Gupta On Oct. 4, 2017, 2:54 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62773/ > ----------------------------------------------------------- > > (Updated Oct. 4, 2017, 2:54 p.m.) > > > Review request for lens and Rajat Khandelwal. > > > Repository: lens > > > Description > ------- > > Fix for column start times not working in Virtual facts > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fd07bf2 > > > Diff: https://reviews.apache.org/r/62773/diff/3/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
