----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62773/#review187742 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java Lines 343 (patched) <https://reviews.apache.org/r/62773/#comment264790> Does it make sense to have this method in CubeVirtualFactTable ? lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java Lines 345 (patched) <https://reviews.apache.org/r/62773/#comment264789> Should we use org.apache.lens.cube.metadata.FactTable#isVirtualFact? - Puneet Gupta On Oct. 11, 2017, 10:50 a.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62773/ > ----------------------------------------------------------- > > (Updated Oct. 11, 2017, 10:50 a.m.) > > > Review request for lens and Rajat Khandelwal. > > > Bugs: LENS-1480 > https://issues.apache.org/jira/browse/LENS-1480 > > > Repository: lens > > > Description > ------- > > Fix for column start times not working in Virtual facts > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fd07bf2 > > > Diff: https://reviews.apache.org/r/62773/diff/5/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
