----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63665/#review190674 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java Lines 196 (patched) <https://reviews.apache.org/r/63665/#comment268246> This is unrelated to current JIRA . lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java Line 322 (original), 322 (patched) <https://reviews.apache.org/r/63665/#comment268247> Unrelated to JIRA LENS-1483. Please post in a separate request lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java Lines 389 (patched) <https://reviews.apache.org/r/63665/#comment268249> This code seems common for Hive and JDBC driver. Is it possible to move this to AbstarctDriver and use a common property ? lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java Lines 48 (patched) <https://reviews.apache.org/r/63665/#comment268250> is it possible to make < 0.0, 0.0, >0.0 configureable ? lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java Lines 60 (patched) <https://reviews.apache.org/r/63665/#comment268251> Can we have all common methods in a base abstract class AbstractQueryCost for StaticQueryCost and FactPartitionBasedQueryCost to extend it ? - Puneet Gupta On Nov. 8, 2017, 12:43 p.m., Rajitha R wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63665/ > ----------------------------------------------------------- > > (Updated Nov. 8, 2017, 12:43 p.m.) > > > Review request for lens and Puneet Gupta. > > > Bugs: LENS-1483 > https://issues.apache.org/jira/browse/LENS-1483 > > > Repository: lens > > > Description > ------- > > Jdbc driver cost has been hardcoded to zero currently in Lens code. This > makes it difficult to add more jdbc drivers which have different costs. Hence > there is a need for having a driver level implementation for calculating cost. > > > Diffs > ----- > > lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 37eda42 > > lens-cube/src/main/java/org/apache/lens/cube/metadata/CubeVirtualFactTable.java > 8b55985 > lens-cube/src/main/java/org/apache/lens/cube/parse/StorageCandidate.java > fd07bf2 > > lens-cube/src/main/java/org/apache/lens/cube/query/cost/StaticCostCalculator.java > PRE-CREATION > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > 528f857 > > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java > 51abc96 > lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 5545fac > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > 446e759 > > lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java > 7fd487c > > lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java > PRE-CREATION > > lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java > e047c91 > src/site/apt/admin/jdbcdriver-config.apt eb56927 > > > Diff: https://reviews.apache.org/r/63665/diff/2/ > > > Testing > ------- > > > Thanks, > > Rajitha R > >
