----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63665/ -----------------------------------------------------------
(Updated Nov. 14, 2017, 12:36 p.m.) Review request for lens and Puneet Gupta. Bugs: LENS-1483 https://issues.apache.org/jira/browse/LENS-1483 Repository: lens Description ------- Jdbc driver cost has been hardcoded to zero currently in Lens code. This makes it difficult to add more jdbc drivers which have different costs. Hence there is a need for having a driver level implementation for calculating cost. Diffs (updated) ----- lens-api/src/main/java/org/apache/lens/api/query/QueryCostType.java 37eda42 lens-cube/src/main/java/org/apache/lens/cube/query/cost/FactPartitionBasedQueryCostCalculator.java 3c157ee lens-cube/src/main/java/org/apache/lens/cube/query/cost/StaticCostCalculator.java PRE-CREATION lens-cube/src/test/java/org/apache/lens/cube/query/cost/TestFactPartitionBasedQueryCostCalculator.java b5e73fd lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java 0b4db9a lens-driver-hive/src/main/resources/hivedriver-default.xml a13d3b0 lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java 1261409 lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java 528f857 lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriverConfConstants.java 51abc96 lens-driver-jdbc/src/main/resources/jdbcdriver-default.xml 5545fac lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java 446e759 lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java 7fd487c lens-server-api/src/main/java/org/apache/lens/server/api/driver/DriverQueryPlan.java 2036dce lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/FactPartitionBasedQueryCost.java eba8f0d lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCost.java 9d7320a lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostCalculator.java 8c71c00 lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTypeDecider.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/QueryCostTypeRangeConf.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/RangeBasedQueryCostTypeDecider.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/cost/StaticQueryCost.java PRE-CREATION lens-server-api/src/main/java/org/apache/lens/server/api/query/priority/RangeConf.java 43cc53c lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/MockQueryCostCalculator.java fb4085e lens-server-api/src/test/java/org/apache/lens/server/api/query/cost/TestFactPartitionBasedQueryCost.java e047c91 src/site/apt/admin/jdbcdriver-config.apt eb56927 Diff: https://reviews.apache.org/r/63665/diff/7/ Changes: https://reviews.apache.org/r/63665/diff/6-7/ Testing ------- Thanks, Rajitha R