RajashekharChoukimath commented on a change in pull request #34: [LENS-1545]:
Fixed a Bug and made changes for PreparedQuery.
URL: https://github.com/apache/lens/pull/34#discussion_r303315570
##########
File path:
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
##########
@@ -735,7 +738,7 @@ private PreparedStatement
prepareInternal(AbstractQueryContext pContext,
// Only create a prepared statement and then close it
MethodMetricsContext sqlRewriteGauge =
MethodMetricsFactory.createMethodGauge(pContext.getDriverConf(this), true,
metricCallStack + COLUMNAR_SQL_REWRITE_GAUGE);
- String rewrittenQuery = rewriteQuery(pContext);
Review comment:
Explain also works fine because of the below stack trace:
JDBCDriver.rewriteQuery(AbstractQueryContext) line: 529
JDBCDriver.explain(AbstractQueryContext) line: 582
QueryExecutionServiceImpl.explain(String, LensSessionHandle, String,
LensConf) line: 3141
Explain was also try to make JDBC connection, I have stopped this using
JDBC_VALIDATE_THROUGH_PREPARE(I have renamed this variable to
JDBC_VALIDATE_THROUGH_PREPARE_OR_EXPLAIN).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
