RajashekharChoukimath commented on a change in pull request #34: [LENS-1545]:
Fixed a Bug and made changes for PreparedQuery.
URL: https://github.com/apache/lens/pull/34#discussion_r305828088
##########
File path:
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
##########
@@ -2054,7 +2057,12 @@ public QueryPrepareHandle prepare(LensSessionHandle
sessionHandle, String query,
acquire(sessionHandle);
prepared = prepareQuery(sessionHandle, query, lensConf,
SubmitOp.PREPARE);
prepared.setQueryName(queryName);
- prepared.getSelectedDriver().prepare(prepared);
+ try {
+ lensServerDao.insertPreparedQuery(prepared);
+ } catch (Exception e) {
+ incrCounter(PREPARED_QUERY_INSERT_COUNTER);
Review comment:
the counter name was wrong, i have renamed it to
PREPARED_QUERY_INSERT_ERROR_COUNTER and also throwed the exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
