ankitkailaswar commented on a change in pull request #34: [LENS-1545]: Fixed a
Bug and made changes for PreparedQuery.
URL: https://github.com/apache/lens/pull/34#discussion_r303304202
##########
File path:
lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java
##########
@@ -2054,8 +2056,14 @@ public QueryPrepareHandle prepare(LensSessionHandle
sessionHandle, String query,
acquire(sessionHandle);
prepared = prepareQuery(sessionHandle, query, lensConf,
SubmitOp.PREPARE);
prepared.setQueryName(queryName);
- prepared.getSelectedDriver().prepare(prepared);
+ try {
Review comment:
I assume we are capturing query prepare time for lens query to monitor its
performance. If that's the case its always better to emit metric that indicates
average prepare query time over last 5 mins, 60 min, etc.
PREPARED_QUERIES_COUNTER is different counter I am asking you to emit one for
prepare time with aggregation that can be used to raise an alert. To monitor
performance by looking into db is not good practice. It is being used mostly
for bookkeeping.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
