[
https://issues.apache.org/jira/browse/LENS-1545?focusedWorklogId=274799&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274799
]
ASF GitHub Bot logged work on LENS-1545:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/19 11:33
Start Date: 10/Jul/19 11:33
Worklog Time Spent: 10m
Work Description: ankitkailaswar commented on pull request #34:
[LENS-1545]: Fixed a Bug and made changes for PreparedQuery.
URL: https://github.com/apache/lens/pull/34#discussion_r301535590
##########
File path:
lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java
##########
@@ -735,7 +738,7 @@ private PreparedStatement
prepareInternal(AbstractQueryContext pContext,
// Only create a prepared statement and then close it
MethodMetricsContext sqlRewriteGauge =
MethodMetricsFactory.createMethodGauge(pContext.getDriverConf(this), true,
metricCallStack + COLUMNAR_SQL_REWRITE_GAUGE);
- String rewrittenQuery = rewriteQuery(pContext);
Review comment:
rewrite query is called for estimate, prepare, explain etc. In this case
estimate will work fine. explain will fail to initialize "String
rewrittenQuery" since rewriteQuery was never called and
pContext.getSelectedDriverQuery(); will be null.
Exsisting unit test must have failed for this scenario. Please run unit
tests.
Also I wouldnt recoomend this approach since we have to call rewrite for
estimate/prepare/explaing etc.
Please make it config driven in estimate call.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 274799)
Time Spent: 10m
Remaining Estimate: 0h
> Fixed a Bug and made changes for PreparedQuery
> ----------------------------------------------
>
> Key: LENS-1545
> URL: https://issues.apache.org/jira/browse/LENS-1545
> Project: Apache Lens
> Issue Type: Improvement
> Components: api, cube, server
> Reporter: Rajashekhar
> Assignee: Amareshwari Sriramadasu
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Fixed following Issues in Lens for Azure Migrations
> # Bug in Lens-Metastore for single fact granularity --
> https://issues.apache.org/jira/browse/LENS-1544. Explaination: This had a
> special case for handling facts with one-update-period and
> multiple-update-periods. The case which handled one-update-period had a bug
> while generating the name of the hive table whole format is
> update_period-fact_name, the update_period was coming as null.
> # JDBCDriver.java was invoking JDBC Driver while validating the prepared
> query, I don't need this functionality so blocking this via already existing
> config parameter JDBC_VALIDATE_THROUGH_PREPARE.
> 2a) Old Flow:
> {code}
> esitmate()
> --- | --> validate
> -----| --> JDBC_VALIDATE_THROUGH_PREPARE condition to prepare through if
> condition
> -----|--> prepareInternal()
> ----------------|--> rewrite -- Rewritting take place
> {code}
> 2b) New Flow:
> {code}
> esitmate()
> ---| --> rewrite -- Rewritting take place
> ---| --> validate
> -----| --> JDBC_VALIDATE_THROUGH_PREPARE condition to prepare through if
> condition
> -----|--> prepareInternal()
> {code}
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
