----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28540/#review63307 -----------------------------------------------------------
lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java <https://reviews.apache.org/r/28540/#comment105506> Shouldnt the conf be selected driver conf here? lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java <https://reviews.apache.org/r/28540/#comment105507> Again, shouldnt the conf be selected driver conf here? lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java <https://reviews.apache.org/r/28540/#comment105505> Comment to do with adding jdbc xml can be removed lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java <https://reviews.apache.org/r/28540/#comment105508> This should be marked transient. And to save selected driver query across restarts. You can have private local variable to store selected driver query which is not transient Is setter required for driverContext? lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java <https://reviews.apache.org/r/28540/#comment105509> Is this constructor useful without setting driverContext? lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java <https://reviews.apache.org/r/28540/#comment105510> Shouldnt be seriazable, because we dont want to serialize selectedDriver or the map of context lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java <https://reviews.apache.org/r/28540/#comment105511> Need to check if this constructor is useful anywhere? lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java <https://reviews.apache.org/r/28540/#comment105512> Need to check if this constructor is useful - Amareshwari Sriramadasu On Nov. 30, 2014, 5:58 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28540/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2014, 5:58 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-20 > https://issues.apache.org/jira/browse/LENS-20 > > > Repository: lens > > > Description > ------- > > Driver specific query conf is being merged currently at multiple places in > code. Consolidating this in DriverSelectorQueryContext > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > 9c76271 > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java > a3df316 > lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java > 538d27d > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 65d6988 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java > c9ab9bd > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > dfbdb79 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > c213709 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > f073203 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > fafa1a5 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > c2d38fc > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java > 6c42795 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java > 6763e2e > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java > c4d6b6d > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 0b3e976 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 0098a1a > > lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java > e248437 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java > ed592a5 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 04b8aa4 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > a3144f0 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java > bb22df0 > tools/conf/server/hivedriver-site.xml f179ecd > tools/conf/server/jdbcdriver-site.xml 235187a > > Diff: https://reviews.apache.org/r/28540/diff/ > > > Testing > ------- > > > Thanks, > > Suma Shivaprasad > >
