> On Nov. 30, 2014, 6:57 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java, > > line 53 > > <https://reviews.apache.org/r/28540/diff/1/?file=778615#file778615line53> > > > > This should be marked transient. > > > > And to save selected driver query across restarts. You can have private > > local variable to store selected driver query which is not transient > > > > Is setter required for driverContext?
setter is needed since resurrection of QueryContext.DriverSelectorContext is done through setter > On Nov. 30, 2014, 6:57 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java, > > line 55 > > <https://reviews.apache.org/r/28540/diff/1/?file=778615#file778615line55> > > > > Is this constructor useful without setting driverContext? removed > On Nov. 30, 2014, 6:57 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 141 > > <https://reviews.apache.org/r/28540/diff/1/?file=778619#file778619line141> > > > > Need to check if this constructor is useful anywhere? removed > On Nov. 30, 2014, 6:57 a.m., Amareshwari Sriramadasu wrote: > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java, > > line 219 > > <https://reviews.apache.org/r/28540/diff/1/?file=778619#file778619line219> > > > > Need to check if this constructor is useful It is being used in UTs - Suma ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/28540/#review63307 ----------------------------------------------------------- On Nov. 30, 2014, 10:29 a.m., Suma Shivaprasad wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/28540/ > ----------------------------------------------------------- > > (Updated Nov. 30, 2014, 10:29 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-20 > https://issues.apache.org/jira/browse/LENS-20 > > > Repository: lens > > > Description > ------- > > Driver specific query conf is being merged currently at multiple places in > code. Consolidating this in DriverSelectorQueryContext > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/driver/cube/RewriteUtil.java > 9c76271 > > lens-cube/src/test/java/org/apache/lens/driver/cube/TestMinCostSelector.java > a3df316 > lens-cube/src/test/java/org/apache/lens/driver/cube/TestRewriting.java > 538d27d > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/HiveDriver.java > 65d6988 > > lens-driver-hive/src/main/java/org/apache/lens/driver/hive/priority/DurationBasedQueryPriorityDecider.java > c9ab9bd > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestHiveDriver.java > dfbdb79 > > lens-driver-hive/src/test/java/org/apache/lens/driver/hive/TestRemoteHiveDriver.java > c213709 > lens-driver-jdbc/src/main/java/org/apache/lens/driver/jdbc/JDBCDriver.java > f073203 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJDBCFinal.java > fafa1a5 > > lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestJdbcDriver.java > c2d38fc > > lens-query-lib/src/test/java/org/apache/lens/lib/query/TestAbstractFileFormatter.java > c0b5177 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MinQueryCostSelector.java > 6c42795 > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockDriver.java > 6763e2e > > lens-server-api/src/main/java/org/apache/lens/server/api/driver/MockQueryContext.java > c4d6b6d > > lens-server-api/src/main/java/org/apache/lens/server/api/query/AbstractQueryContext.java > 0b3e976 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/DriverSelectorQueryContext.java > 0098a1a > > lens-server-api/src/main/java/org/apache/lens/server/api/query/ExplainQueryContext.java > e248437 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/PreparedQueryContext.java > ed592a5 > > lens-server-api/src/main/java/org/apache/lens/server/api/query/QueryContext.java > 04b8aa4 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionServiceImpl.java > a3144f0 > > lens-server/src/main/java/org/apache/lens/server/query/QueryExecutionStatisticsGenerator.java > bb22df0 > tools/conf/server/hivedriver-site.xml f179ecd > tools/conf/server/jdbcdriver-site.xml 235187a > > Diff: https://reviews.apache.org/r/28540/diff/ > > > Testing > ------- > > > Thanks, > > Suma Shivaprasad > >
