[
https://issues.apache.org/jira/browse/LENS-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258687#comment-14258687
]
Jaideep Dhok commented on LENS-83:
----------------------------------
Reference -
[ServerSocket|http://docs.oracle.com/javase/7/docs/api/java/net/ServerSocket.html#ServerSocket%28int%29]
"A port number of 0 means that the port number is automatically allocated,
typically from an ephemeral port range. "
> All tests should use available ports instead of using some fixed/static port
> ----------------------------------------------------------------------------
>
> Key: LENS-83
> URL: https://issues.apache.org/jira/browse/LENS-83
> Project: Apache Lens
> Issue Type: Sub-task
> Components: test
> Reporter: Raju Bairishetti
> Assignee: Raju Bairishetti
> Fix For: 2.0
>
>
> C1MNG0PXDTY3:incubator-lens raju.bairishetti$ grep -r "getTestPort" * | grep
> -v class | wc -l
> 16
> Right now, 16 tests are using on some fixed port number. This would be a
> problem in future if user wants to add a new test case. *User has to know all
> the 16 ports which are already occupied by test cases.*
> *Fix: Tests Should use free/available port instead of using fixed/static
> port.*
> Tests which are having dependency on ports:
> ---------------------------------------------------------------
> {noformat}
> C1MNG0PXDTY3:incubator-lens raju.bairishetti$ grep -r "getTestPort" * | grep
> -v class
> lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java:
> protected int getTestPort() {
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java: protected
> int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:
> return UriBuilder.fromUri("http://localhost/";).port(getTestPort()).build();
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:
> protected abstract int getTestPort();
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java:
> return UriBuilder.fromUri("http://localhost/";).port(getTestPort()).build();
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
