[
https://issues.apache.org/jira/browse/LENS-83?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14301149#comment-14301149
]
Hudson commented on LENS-83:
----------------------------
SUCCESS: Integrated in Lens-Commit #103 (See
[https://builds.apache.org/job/Lens-Commit/103/])
LENS-83 : All tests should use available ports instead of using some
fixed/static port (Raju bairishetti via amareshwari) (amareshwari.sr: rev
f5153491e1ac1753078e4c385595df8b84029282)
*
lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java
*
lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java
* lens-cli/src/test/resources/lens-client-site.xml
* lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java
* lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java
* lens-client/src/test/resources/lens-client-site.xml
*
lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java
* lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java
* lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java
* lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java
* lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java
* lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java
* lens-client/src/main/java/org/apache/lens/client/LensClientConfig.java
* lens-server/src/test/java/org/apache/lens/server/TestServerMode.java
* lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java
* lens-client/src/test/java/org/apache/lens/client/TestLensClient.java
* lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java
> All tests should use available ports instead of using some fixed/static port
> ----------------------------------------------------------------------------
>
> Key: LENS-83
> URL: https://issues.apache.org/jira/browse/LENS-83
> Project: Apache Lens
> Issue Type: Sub-task
> Components: test
> Reporter: Raju Bairishetti
> Assignee: Raju Bairishetti
> Fix For: 2.0
>
> Attachments: LENS-83.patch
>
>
> C1MNG0PXDTY3:incubator-lens raju.bairishetti$ grep -r "getTestPort" * | grep
> -v class | wc -l
> 16
> Right now, 16 tests are using on some fixed port number. This would be a
> problem in future if user wants to add a new test case. *User has to know all
> the 16 ports which are already occupied by test cases.*
> *Fix: Tests Should use free/available port instead of using fixed/static
> port.*
> Tests which are having dependency on ports:
> ---------------------------------------------------------------
> {noformat}
> C1MNG0PXDTY3:incubator-lens raju.bairishetti$ grep -r "getTestPort" * | grep
> -v class
> lens-cli/src/test/java/org/apache/lens/cli/LensCliApplicationTest.java:
> protected int getTestPort() {
> lens-ml-lib/src/test/java/org/apache/lens/ml/TestMLResource.java: protected
> int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:
> return UriBuilder.fromUri("http://localhost/";).port(getTestPort()).build();
> lens-server/src/test/java/org/apache/lens/server/LensJerseyTest.java:
> protected abstract int getTestPort();
> lens-server/src/test/java/org/apache/lens/server/metastore/TestMetastoreService.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/query/TestLensDAO.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/query/TestQueryService.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/query/TestResultFormatting.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/session/TestSessionResource.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestIndexResource.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestLensApplication.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestServerMode.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestServerRestart.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestServiceProvider.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java:
> protected int getTestPort() {
> lens-server/src/test/java/org/apache/lens/server/TestStaticFileResource.java:
> return UriBuilder.fromUri("http://localhost/";).port(getTestPort()).build();
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
