> On Dec. 25, 2014, 5:45 p.m., Jaideep dhok wrote: > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java, > > line 739 > > <https://reviews.apache.org/r/29422/diff/1/?file=800741#file800741line739> > > > > Can you use the twoDaysRange or some other time range for the where > > clause, I think hardcoded dates might not work as partitions are added > > dynamically during test setup. > > > > For comparing queries too, there is a utility method in CubeTestSetup
Test case is passing with constant input dates in queries. I might be missing something. Please help me in understanding when will the test case not work with constant dates. Focus of the test case is testing promotion, which is getting achieved with the written test case. Wanted to keep the dependencies of test case as less as possible and also keep it as simple as possible so that it is easier to understand. Also since assertEquals is working, what is the advantage in using compareQueries and increasing dependency in test case ? - Himanshu ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29422/#review66101 ----------------------------------------------------------- On Dec. 25, 2014, 5:40 p.m., Himanshu Gahlaut wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29422/ > ----------------------------------------------------------- > > (Updated Dec. 25, 2014, 5:40 p.m.) > > > Review request for lens. > > > Repository: lens > > > Description > ------- > > (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle > aliases with spaces in them. Fixed the same. > (2) Also improved log4j.properties of lens-cube to send logs to both console > appender and test log files. > (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j > logger. Added required dependencies in lens-cube/pom.xml to facilitate the > same. > > > Diffs > ----- > > lens-cube/pom.xml 1bcb4dc > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > c2fef7e > lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java > ad4abcf > lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java > fd939e9 > lens-cube/src/test/resources/log4j.properties 9729de0 > > Diff: https://reviews.apache.org/r/29422/diff/ > > > Testing > ------- > > Added a unit test case for the same. > > > Thanks, > > Himanshu Gahlaut > >
