----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29422/ -----------------------------------------------------------
(Updated Dec. 25, 2014, 8:02 p.m.) Review request for lens. Changes ------- (1) Created a lastHourTimeRange and used that in unit test case. (2) Used Different Levels for STDOUT and TEST FILE logging. WARN for STDOUT and DEBUG for TEST LOG FILE. Repository: lens Description ------- (1) getExpressionWithoutAlias in GroupbyResolver.class is unable to handle aliases with spaces in them. Fixed the same. (2) Also improved log4j.properties of lens-cube to send logs to both console appender and test log files. (3) Used Slf4j annotation in Test classes for getting a reference to Slf4j logger. Added required dependencies in lens-cube/pom.xml to facilitate the same. Diffs (updated) ----- lens-cube/pom.xml 1bcb4dc lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java c2fef7e lens-cube/src/test/java/org/apache/lens/cube/parse/CubeTestSetup.java f515df1 lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java ad4abcf lens-cube/src/test/java/org/apache/lens/cube/parse/TestQueryRewrite.java fd939e9 lens-cube/src/test/resources/log4j.properties 9729de0 Diff: https://reviews.apache.org/r/29422/diff/ Testing ------- Added a unit test case for the same. Thanks, Himanshu Gahlaut
