----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29705/#review67390 -----------------------------------------------------------
lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java <https://reviews.apache.org/r/29705/#comment111409> can you add braces around if clauses? lens-cube/src/main/resources/olap-query-conf.xml <https://reviews.apache.org/r/29705/#comment111407> Can we change the name to lens.cube.query.enable.attrfields.add.distinct? Makes more readable. lens-cube/src/main/resources/olap-query-conf.xml <https://reviews.apache.org/r/29705/#comment111408> Change description to 'When the query has only attribute fields projected from cube and the flag is set to true, distinct clause will be added for the projection sothat no duplicate values will be projected. If flag is set to false, projection wont be changed, result might include duplicate values.' lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java <https://reviews.apache.org/r/29705/#comment111406> Whats the rewritten query for 'select count(cityid) from testcube'? We shouldn't be adding distinct for that. Can you add test for the same? - Amareshwari Sriramadasu On Jan. 9, 2015, 7:24 a.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29705/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 7:24 a.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-169 > https://issues.apache.org/jira/browse/LENS-169 > > > Repository: lens > > > Description > ------- > > Currently dimension only queries give duplicate rows when joining with fact > for specified date range. For such queries we should be adding distinct > keyword in the projected column list. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 2d063ef > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 8afaf17 > lens-cube/src/main/resources/olap-query-conf.xml 42bd210 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > e24e0bc > src/site/apt/user/olap-query-conf.apt 2b22e8a > > Diff: https://reviews.apache.org/r/29705/diff/ > > > Testing > ------- > > Tested this by adding new test case. All unit tests are running fine. > > > Thanks, > > Sushil Mohanty > >
