----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/29705/#review67425 -----------------------------------------------------------
Ship it! Ship It! - Amareshwari Sriramadasu On Jan. 9, 2015, 12:32 p.m., Sushil Mohanty wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/29705/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2015, 12:32 p.m.) > > > Review request for lens and Amareshwari Sriramadasu. > > > Bugs: LENS-169 > https://issues.apache.org/jira/browse/LENS-169 > > > Repository: lens > > > Description > ------- > > Currently dimension only queries give duplicate rows when joining with fact > for specified date range. For such queries we should be adding distinct > keyword in the projected column list. > > > Diffs > ----- > > lens-cube/src/main/java/org/apache/lens/cube/parse/AggregateResolver.java > 2d063ef > lens-cube/src/main/java/org/apache/lens/cube/parse/CubeQueryConfUtil.java > 8afaf17 > lens-cube/src/main/java/org/apache/lens/cube/parse/GroupbyResolver.java > ee61aaa > lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 3c551c2 > lens-cube/src/main/resources/olap-query-conf.xml 42bd210 > > lens-cube/src/test/java/org/apache/lens/cube/parse/TestAggregateResolver.java > e24e0bc > src/site/apt/user/olap-query-conf.apt 2b22e8a > > Diff: https://reviews.apache.org/r/29705/diff/ > > > Testing > ------- > > Tested this by adding new test case. All unit tests are running fine. > > > Thanks, > > Sushil Mohanty > >
