> On Jan. 9, 2015, 5:19 a.m., Rajat Khandelwal wrote:
> > tools/scripts/lens-config.sh, line 98
> > <https://reviews.apache.org/r/29706/diff/1/?file=812947#file812947line98>
> >
> >     Shouldn't always remove and re-expand the war. 
> >     
> >     The earlier setup provided a hook for updating a jar inside the war and 
> > restarting the server for quick (test/dev) deployment. Now we'll have to 
> > bundle the war each time. e.g. sometimes when my changes are localized to a 
> > module, I build only that jar and put it directly inside WEB-INF/lib of the 
> > expanded war. This change takes away that hook.
> >     
> >     Instead, we should delete the expanded war on each re-deployment. Let's 
> > not modify lens-ctl, only debian steps.
> 
> Himanshu Gahlaut wrote:
>     As discussed with Rajat offline, Objective: "sometimes when my changes 
> are localized to a module, I build only that jar and put it directly inside 
> WEB-INF/lib of the expanded war." is still achievable.

Yes. Should be still achievable


- Amareshwari


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29706/#review67373
-----------------------------------------------------------


On Jan. 8, 2015, 11:12 a.m., Himanshu Gahlaut wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29706/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2015, 11:12 a.m.)
> 
> 
> Review request for lens.
> 
> 
> Repository: lens
> 
> 
> Description
> -------
> 
> LENS-181
> 
> Created postinst script for lens server debian.
> Added war-expansion functionality in postinst script.
> 
> 
> Diffs
> -----
> 
>   lens-dist/pom.xml f3c5463 
>   lens-dist/src/deb/control/postinst PRE-CREATION 
>   pom.xml 079971f 
>   tools/scripts/lens-config.sh 8bd9013 
> 
> Diff: https://reviews.apache.org/r/29706/diff/
> 
> 
> Testing
> -------
> 
> Debian installation successful.
> 
> root@34932e553229:/opt/lens# dpkg -i 
> lens-dist/target/lens-server_2.0.0-SNAPSHOT.deb 
> (Reading database ... 24319 files and directories currently installed.)
> Preparing to unpack .../lens-server_2.0.0-SNAPSHOT.deb ...
> Unpacking lens-server (2.0.0-SNAPSHOT) over (2.0.0-SNAPSHOT) ...
> Setting up lens-server (2.0.0-SNAPSHOT) ...
> /
> 
> 
> Thanks,
> 
> Himanshu Gahlaut
> 
>

Reply via email to